Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty bin field #967

Closed
dacevedo12 opened this issue Oct 10, 2022 · 0 comments · Fixed by #969
Closed

Handle empty bin field #967

dacevedo12 opened this issue Oct 10, 2022 · 0 comments · Fixed by #969

Comments

@dacevedo12
Copy link
Collaborator

in some package.json files, there is a bin field but it may be empty (e.g. https://github.com/peterolson/BigInteger.js/blob/master/package.json#L7).

The current builder script for makeNodeJsModules fails in this case
@dacevedo12 dacevedo12 mentioned this issue Oct 13, 2022
Merged
kamadorueda added a commit that referenced this issue Oct 13, 2022
@kamadorueda
Merge pull request #969 from dacevedo12/dacevedo
22c92c3 
fix(build): #967 nodejs binaries
github-actions bot added a commit that referenced this issue Oct 13, 2022
@github-actions
Merge pull request #969 from dacevedo12/dacevedo
c40184a 
fix(build): #967 nodejs binaries
danmur97 pushed a commit to danmur97/makes that referenced this issue Oct 24, 2022
@dacevedo12 @danmur97
fix(build): fluidattacks#967 nodejs binaries
2163ecf 
- allow bin to be empty as some packages require it

Signed-off-by: David Acevedo <dacevedoa12@gmail.com>
danmur97 pushed a commit to danmur97/makes that referenced this issue Oct 25, 2022
@dacevedo12 @danmur97
fix(build): fluidattacks#967 nodejs binaries
6df7a1c 
- allow bin to be empty as some packages require it

Signed-off-by: David Acevedo <dacevedoa12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): #967 nodejs binaries
1 participant
@dacevedo12