Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(back): #1343 deprecate args git fetchers #1344

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

rohaquinlop
Copy link
Collaborator

  • Remove fetchGithub and fetchGitlab from the agnostic.nix file.
  • Replace fetchGithub and fetchGitlab with builtins.fetchTarball in the fetch-nix,
    lint-git-mailmap and
    secure-kubernetes-with-rbac-police args.
  • Update the fetchers documentation.
  • The only fetchGit in the project is in the src/nix/sources.nix file, which is generated by
    Niv.

- Remove `fetchGithub` and `fetchGitlab` from
the agnostic.nix file.
- Replace `fetchGithub` and `fetchGitlab` with
`builtins.fetchTarball` in the `fetch-nix`,
`lint-git-mailmap` and
`secure-kubernetes-with-rbac-police` args.
- Update the fetchers documentation.
- The only `fetchGit` in the project is in the
`src/nix/sources.nix` file, which is generated by
Niv.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
Copy link
Contributor

@dsalaza4 dsalaza4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dsalaza4 dsalaza4 merged commit 0fb94bc into fluidattacks:main Jun 26, 2024
73 of 77 checks passed
@rohaquinlop rohaquinlop deleted the issue-1343 branch June 26, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants