fix: check if folder is writeable on file drop

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
fluidd-core · Oct 12, 2023 · d53462e · d53462e
1 parent 50ac181
commit d53462e
Showing 1 changed file with 16 additions and 9 deletions.
diff --git a/src/components/widgets/filesystem/FileSystemBrowser.vue b/src/components/widgets/filesystem/FileSystemBrowser.vue
@@ -34,7 +34,7 @@
             'v-data-table__selected': (isSelected && item.name !== '..')
           }"
           class="row-select px-1"
-          :draggable="draggable(item)"
+          :draggable="isItemDraggable(item)"
           @click.prevent="$emit('row-click', item, $event)"
           @contextmenu.prevent="$emit('row-click', item, $event)"
           @dragstart="handleDragStart(item, $event)"
@@ -387,13 +387,7 @@ export default class FileSystemBrowser extends Mixins(FilesMixin) {
   }
 
   getItemIcon (item: FileBrowserEntry) {
-    const readonly = (
-      this.readonly ||
-      (
-        item.permissions !== undefined &&
-        !item.permissions.includes('w')
-      )
-    )
+    const readonly = !this.isItemWriteable(item)
 
     if (item.type === 'file') {
       if (item.extension === 'zip') {
@@ -414,7 +408,7 @@ export default class FileSystemBrowser extends Mixins(FilesMixin) {
   }
 
   // Determines if a row is currently in a draggable state or not.
-  draggable (item: FileBrowserEntry) {
+  isItemDraggable (item: FileBrowserEntry) {
     return (
       item.name !== '..' &&
       this.files.length > 0 &&
@@ -425,6 +419,17 @@ export default class FileSystemBrowser extends Mixins(FilesMixin) {
     )
   }
 
+  isItemWriteable (item: FileBrowserEntry) {
+    return (
+      item.name !== '..' &&
+      !this.readonly &&
+      (
+        item.permissions === undefined ||
+        item.permissions.includes('w')
+      )
+    )
+  }
+
   // Fake a drag image when the user drags a file or folder.
   handleDragStart (item: FileBrowserEntry, e: DragEvent) {
     if (this.dragState !== true) {
@@ -460,6 +465,7 @@ export default class FileSystemBrowser extends Mixins(FilesMixin) {
 
     if (
       item.type === 'directory' &&
+      this.isItemWriteable(item) &&
       e.dataTransfer &&
       this.dragItem &&
       this.dragItem !== item
@@ -476,6 +482,7 @@ export default class FileSystemBrowser extends Mixins(FilesMixin) {
   handleDragOver (item: FileBrowserEntry, e: DragEvent) {
     if (
       item.type === 'directory' &&
+      this.isItemWriteable(item) &&
       e.dataTransfer &&
       this.dragItem &&
       this.dragItem !== item &&