feat: setting to disable automatic gcode loading on mobile #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieraneglin
commented
Feb 4, 2023
|
Thank you @kieraneglin, can you please add a footer to the main PR comment with a "Signed-off-by" line, following the CONTRIBUTING guidelines (you are missing the email address on yours!) Thank you! |
|
@pedrolamas added my email! |
kieraneglin
commented
Feb 4, 2023
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934.
Automatic gcode loading works well on computers, but on mobile browsers it can take away control for several seconds, especially on remote connections. This PR adds a new setting to allow different loading behaviours on mobile vs. desktop.
Note: the label text could definitely use an editorial review.
Signed-off-by: Kieran Eglin kieran.eglin@gmail.com