Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FormBuilderRadioGroup separator #1106

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Improve FormBuilderRadioGroup separator #1106

merged 1 commit into from
Aug 13, 2022

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented Aug 13, 2022

Connection with issue(s)

Close #1104

Solution description

  • FormBuilderRadioGroup: Move separator above Radio when set Orientation.vertical

Screenshots or Videos

Vertical:
1104

Horizontal:
1104-horizontal

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #1106 (f8abda8) into main (956cd08) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
+ Coverage   71.55%   71.57%   +0.01%     
==========================================
  Files          19       19              
  Lines         703      707       +4     
==========================================
+ Hits          503      506       +3     
- Misses        200      201       +1     
Impacted Files Coverage Δ
lib/src/widgets/grouped_radio.dart 79.24% <75.00%> (-0.35%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit a81c3f3 into main Aug 13, 2022
@deandreamatias deandreamatias deleted the 1104 branch August 13, 2022 09:07
@adhikari-suman
Copy link

Why is the text and the radio on opposite side? Are you using rtl layout? Or, have you changed the layout from (Radio - Conteent) to (Content - Radio)?

@deandreamatias deandreamatias restored the 1104 branch August 17, 2022 05:24
@deandreamatias deandreamatias deleted the 1104 branch August 17, 2022 05:24
@deandreamatias
Copy link
Collaborator Author

I really don't know why. I will check whats happens and make a pr if necessary.
Nice catch

@deandreamatias
Copy link
Collaborator Author

@ExpertKiD I discovered why this happens. In example code is set controlAffinity: ControlAffinity.trailing so the radio button is move to right side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants