Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding textAlignVertical support on FormBuilderDateRangePicker and FormBuilderDateTimePicker #1116

Merged

Conversation

arguswaikhom
Copy link
Contributor

@arguswaikhom arguswaikhom commented Sep 20, 2022

Connection with issue(s)

Close #1114

Connected to #???

Solution description

Adding textAlignVertical to allow setting vertical alignment of the TextField in FormBuilderDateRangePicker and FormBuilderDateTimePicker.

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1116 (0f4810a) into main (9348c10) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1116   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          19       19           
  Lines         703      703           
=======================================
  Hits          502      502           
  Misses        201      201           
Impacted Files Coverage Δ
lib/src/fields/form_builder_date_range_picker.dart 0.00% <ø> (ø)
lib/src/fields/form_builder_date_time_picker.dart 90.52% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit e8302de into flutter-form-builder-ecosystem:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to set textAlignVertical on fields like date picker or date range picker?
2 participants