Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Able to change dynamically field name #1178

Merged
merged 1 commit into from
Jan 22, 2023
Merged

feat: Able to change dynamically field name #1178

merged 1 commit into from
Jan 22, 2023

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented Jan 22, 2023

Connection with issue(s)

Close #1173

Solution description

If update name field of same widget, works fine

Screenshots or Videos

Screencast.from.22-01-23.01.54.38.webm

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Merging #1178 (2468d2b) into main (4a3db67) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
- Coverage   84.35%   83.99%   -0.36%     
==========================================
  Files          19       19              
  Lines         703      706       +3     
==========================================
  Hits          593      593              
- Misses        110      113       +3     
Impacted Files Coverage Δ
lib/src/form_builder_field.dart 79.01% <0.00%> (-3.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 9742864 into main Jan 22, 2023
@deandreamatias deandreamatias deleted the 1173 branch January 22, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when name of field is changed
1 participant