Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove input decoration #1238

Merged
merged 4 commits into from
May 6, 2023
Merged

Remove input decoration #1238

merged 4 commits into from
May 6, 2023

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented May 6, 2023

Solution description

BREAKING CHANGE

Add widget to remove decoration property from core. Now exist two field widgets:

  1. FormBuilderField: Refactored. Now don't included decoration property or references to this property
  2. FormBuilderFieldDecoration: New. Like the old FormBuilderField

The main goal for this change is made more pure the FormBuilderField. Now in this widget (and others) only need import package:flutter/widgets.dart and no anymore the material package.
This is useful to create field inputs to others platforms or with other styles, like cupertino.

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #1238 (1b47063) into main (2e69a96) will decrease coverage by 0.10%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
- Coverage   85.77%   85.67%   -0.10%     
==========================================
  Files          20       21       +1     
  Lines         724      733       +9     
==========================================
+ Hits          621      628       +7     
- Misses        103      105       +2     
Impacted Files Coverage Δ
lib/src/extensions/autovalidatemode_extension.dart 100.00% <ø> (ø)
lib/src/fields/form_builder_checkbox.dart 100.00% <ø> (ø)
lib/src/fields/form_builder_choice_chips.dart 100.00% <ø> (ø)
lib/src/fields/form_builder_date_range_picker.dart 86.11% <ø> (ø)
lib/src/fields/form_builder_dropdown.dart 95.00% <ø> (ø)
lib/src/fields/form_builder_radio_group.dart 92.30% <ø> (ø)
lib/src/fields/form_builder_slider.dart 97.05% <ø> (ø)
lib/src/fields/form_builder_switch.dart 100.00% <ø> (ø)
lib/src/fields/form_builder_text_field.dart 90.69% <ø> (ø)
lib/src/form_builder.dart 75.28% <ø> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant