Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 687 and 1231 #1239

Merged
merged 2 commits into from
May 6, 2023
Merged

Fix 687 and 1231 #1239

merged 2 commits into from
May 6, 2023

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented May 6, 2023

Connection with issue(s)

Close #687
Close #1231

Solution description

  • Solved assert error on empty String
  • Replace widget for DropdownButtonFormField

Screenshots or Videos

Screencast.from.07-05-23.01.23.14.webm

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #1239 (f7965e0) into main (c48671f) will decrease coverage by 0.55%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##             main    #1239      +/-   ##
==========================================
- Coverage   85.67%   85.12%   -0.55%     
==========================================
  Files          21       21              
  Lines         733      733              
==========================================
- Hits          628      624       -4     
- Misses        105      109       +4     
Impacted Files Coverage Δ
lib/src/fields/form_builder_dropdown.dart 75.00% <64.28%> (-20.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 27366d5 into main May 6, 2023
@deandreamatias deandreamatias deleted the fix-687 branch May 6, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormBuilderDropdown]: use DropdownButtonFormField FormBuilderDropdown assert error with initialValue
1 participant