Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve when show dropdown disabled hint #1255

Merged
merged 1 commit into from
May 18, 2023

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented May 18, 2023

Connection with issue(s)

Close #1242

Solution description

Only show dropdown vale when has value on items

Screenshots or Videos

Screen.Recording.2023-05-18.at.16.03.49.mov

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1255 (649ea3f) into main (ab3b8f7) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
+ Coverage   85.14%   85.24%   +0.09%     
==========================================
  Files          20       20              
  Lines         707      705       -2     
==========================================
- Hits          602      601       -1     
+ Misses        105      104       -1     
Impacted Files Coverage Δ
lib/src/fields/form_builder_dropdown.dart 77.77% <100.00%> (+2.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 96eb532 into main May 18, 2023
@deandreamatias deandreamatias deleted the fix-1242-improve-dropdown-disabled-hint branch May 18, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant