Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check mounted after async #1268

Conversation

agent3bood
Copy link
Contributor

Connection with issue(s)

Close #1210

Solution description

Check if the widget is still mounted after returning from async call.

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1268 (fb9634e) into main (4498e6d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
+ Coverage   84.96%   84.98%   +0.02%     
==========================================
  Files          20       20              
  Lines         705      706       +1     
==========================================
+ Hits          599      600       +1     
  Misses        106      106              
Impacted Files Coverage Δ
lib/src/fields/form_builder_date_time_picker.dart 86.27% <100.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 72534ac into flutter-form-builder-ecosystem:main Jun 26, 2023
@agent3bood agent3bood deleted the fix/DateTimePicker_setState branch June 26, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormBuilderDateTimePicker calendar not disposing properly and crashing
2 participants