Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #111

Merged

Conversation

martijn00
Copy link
Contributor

@martijn00 martijn00 commented Jun 25, 2024

Connection with issue(s)

Close #110

Solution description

Splits up the code into better testable and more maintainable code.

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

Copy link
Contributor

@deandreamatias deandreamatias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on it!
I'm very busy with my studies and work and couldn't continue with the other PR

analysis_options.yaml Outdated Show resolved Hide resolved
example/analysis_options.yaml Outdated Show resolved Hide resolved
example/pubspec.yaml Outdated Show resolved Hide resolved
lib/src/base_validator.dart Show resolved Hide resolved
lib/src/bool/has_numeric_chars_validator.dart Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 95.46828% with 45 lines in your changes missing coverage. Please review.

Project coverage is 95.00%. Comparing base (8f40bc6) to head (9cf707d).

Files Patch % Lines
lib/src/identity/username_validator.dart 72.97% 10 Missing ⚠️
lib/src/core/aggregate_validator.dart 81.81% 2 Missing ⚠️
lib/src/core/compose_validator.dart 75.00% 2 Missing ⚠️
lib/src/core/conditional_validator.dart 77.77% 2 Missing ⚠️
lib/src/core/default_value_validator.dart 75.00% 2 Missing ⚠️
lib/src/core/log_validator.dart 81.81% 2 Missing ⚠️
lib/src/core/not_equal_validator.dart 60.00% 2 Missing ⚠️
lib/src/core/or_validator.dart 75.00% 2 Missing ⚠️
lib/src/core/skip_when_validator.dart 77.77% 2 Missing ⚠️
lib/src/core/transform_validator.dart 77.77% 2 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   93.31%   95.00%   +1.69%     
==========================================
  Files           5       92      +87     
  Lines         613     1002     +389     
==========================================
+ Hits          572      952     +380     
- Misses         41       50       +9     
Flag Coverage Δ
unittests 95.00% <95.46%> (+1.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijn00 martijn00 marked this pull request as ready for review July 3, 2024 21:42
@martijn00
Copy link
Contributor Author

@deandreamatias this is now ready to go!

@deandreamatias deandreamatias merged commit 02eaed6 into flutter-form-builder-ecosystem:main Jul 7, 2024
5 checks passed
@martijn00
Copy link
Contributor Author

@deandreamatias can you make the release?

@deandreamatias
Copy link
Contributor

@martijn00 need more documentation about this changes.

  1. Add breaking changes and how migrate on README
  2. Add link to these section on changelog
  3. Update the table of contents on readme
  4. Update documentation on readme about how add new validator

If you can do this, I will appreciate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants