Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple issues that arose in platform pay on web after the package:web upgrade #1917

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Fix a couple issues that arose in platform pay on web after the package:web upgrade #1917

merged 2 commits into from
Sep 25, 2024

Conversation

cornwe19
Copy link
Contributor

@cornwe19 cornwe19 commented Sep 8, 2024

  • Not calling preventDefault on PlatformPayButton means users will end up with duplicate platform pay requests
  • Calling 'complete' on pay request wasn't working

@cornwe19
Copy link
Contributor Author

cornwe19 commented Sep 8, 2024

@remonh87 couple touchups to platform pay on web when you have time to review

@jonasbark
Copy link
Member

Thanks!

@jonasbark jonasbark merged commit 1c75fe4 into flutter-stripe:main Sep 25, 2024
3 of 5 checks passed
@cornwe19 cornwe19 deleted the bugfix/platform-pay-web-prevent-default branch September 25, 2024 13:40
@cornwe19 cornwe19 restored the bugfix/platform-pay-web-prevent-default branch September 25, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasbark jonasbark jonasbark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cornwe19 @jonasbark