Fix attempt to present view not in hierarchy #1924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a situation when `rootViewController` is not set by the application,
the main view controller is not found, resulting in error:
Attempt to present <STP_Internal_BottomSheetViewController> on
<UIViewController> (from <UIViewController>) whose view is not in
the window hierarchy.
which then prevents the Stripe bottom sheet from showing. Blocking the
payment flow.
To prevent this, a fallback is added to traverse the windows hierarchy
and find the first one that has `isKeyWindow` set to `true`.
Co-authored-by: Bruno Pastre <bruno.pastre@onefootball.com>
|
Thanks for your contribution! This change would be overwritten from the next sync with https://github.com/stripe/stripe-react-native |
|
this is now replaced by PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a situation when
rootViewControlleris not set by the application,the main view controller is not found, resulting in error:
which then prevents the Stripe bottom sheet from showing. Blocking the
payment flow.
To prevent this, a fallback is added to traverse the windows hierarchy
and find the first one that has
isKeyWindowset totrue.Co-authored-by: Bruno Pastre bruno.pastre@onefootball.com