Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum Tizen version 5.5 to 6.0 #66

Merged
merged 3 commits into from
May 17, 2024

Conversation

JSUYA
Copy link
Member

@JSUYA JSUYA commented Apr 25, 2024

  • Remove Tizen 5.5 support.
  • Remove Wearable support.

@JSUYA JSUYA marked this pull request as draft April 25, 2024 10:53
@JSUYA JSUYA force-pushed the remove/5.5 branch 3 times, most recently from d8e2d28 to 5ca40dd Compare April 30, 2024 05:34
@JSUYA
Copy link
Member Author

JSUYA commented Apr 30, 2024

Hi @swift-kim I have a question.
This PR's build test is failing. I tried cleaning local git and building with gclient sync, but i can't reproduce the build failure. Even in my repo where this patch was pushed builds well.
(https://github.com/JSUYA/embedder/actions/runs/8889817049/job/24408777062)

At download.tizen.org, there is a version difference between 5.5 and 6.5 libstdc++, but between 6.0 and 6.5 is not different.
As far as I know, the --system-cxx command should work normally in 6.0 as well.
I haven't found the reason for this. Do you know a solution to this problem?

@swift-kim
Copy link
Member

Everything looks fine but I think you need to clear the GitHub Actions cache (or do not delete Generate Tizen 6.0 sysroot and --target-sysroot).

The gclient sync hook should have generated a Tizen 5.5 sysroot in the default location (src/sysroot) and the files are being cached wrongly.

@JSUYA
Copy link
Member Author

JSUYA commented Apr 30, 2024

Everything looks fine but I think you need to clear the GitHub Actions cache (or do not delete Generate Tizen 6.0 sysroot and --target-sysroot).

Thanks. I will add Generate Tizen 6.0 sysroot.
Actually, I don't know if the cache for the default version worked well. (Part cached with sysroot-5.5)

The gclient sync hook should have generated a Tizen 5.5 sysroot in the default location (src/sysroot) and the files are being cached wrongly.

Because I changed the default version of generate_sysroot.py to 6.0, Tizen 6.0 sysroot is generated in src/sysroot, so I think the sysroot generated with gclient sync + hook is Tizen 6.0 sysroot.
Adding the Generate Tizen 6.0 sysroot job will solve the problem, but I don't know why src/sysroot is not working properly.

@swift-kim
Copy link
Member

Because the sysroot is not generated again (overwritten) if already present (i.e. cached).

Could you please refrain from force-pushing changes? It makes it difficult to track changes and thus is not good for reviewability.

@JSUYA
Copy link
Member Author

JSUYA commented Apr 30, 2024

rebased pr

tools/gn Outdated Show resolved Hide resolved
@JSUYA JSUYA marked this pull request as ready for review May 2, 2024 04:48
@JSUYA
Copy link
Member Author

JSUYA commented May 17, 2024

@swift-kim Could you please approve?, if there is no more code that needs to be fixed. It seems to applied most of the reviews.

@JSUYA JSUYA merged commit 39f7d91 into flutter-tizen:master May 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants