Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tizen_notification] Bump version to 0.2.0 #481

Merged
merged 5 commits into from
Nov 21, 2022
Merged

[tizen_notification] Bump version to 0.2.0 #481

merged 5 commits into from
Nov 21, 2022

Conversation

swift-kim
Copy link
Member

  • Rename some classes and properties. For example,
    • NotificationImage → NotificationIcons
    • Property → NotificationProperty
    • DisplayApplist → NotificationStyle
  • Move TizenNotificationDetails and enum types (SoundType and VibrationType) to types.dart.
  • Set NotificationProperty.disableAppLaunch automatically if appControl is not set.
  • Improve the documentation.
  • Code cleanup and minor bug fixes.

swift-kim
swift-kim commented Nov 17, 2022
View reviewed changes
packages/tizen_notification/lib/src/types.dart Outdated
/// Indicator.
static const int indicator = 1 << 3;
/// Display in the indicator area (the top of the screen).
static const int indicator = 1 << 1 | 1 << 3;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTIFICATION_DISPLAY_APP_TICKER and NOTIFICATION_DISPLAY_APP_INDICATOR do not work in the way they are documented and now they are a single property.

  • NOTIFICATION_DISPLAY_APP_INDICATOR has no effect on mobile (only NOTIFICATION_DISPLAY_APP_TICKER works in an unexpected way).
  • NOTIFICATION_DISPLAY_APP_TICKER is effectively the same as NOTIFICATION_DISPLAY_APP_INDICATOR on RPi.

bbrto21
bbrto21 approved these changes Nov 20, 2022
View reviewed changes
Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JSUYA
JSUYA approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swift-kim swift-kim merged commit 5a898a3 into flutter-tizen:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrto21 bbrto21 bbrto21 approved these changes

@JSUYA JSUYA JSUYA approved these changes

Assignees
No one assigned
Labels
p: tizen_notification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swift-kim @bbrto21 @JSUYA