Sync with analysis_options.yaml in flutter/packages #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some packages require package upgrade rather than simple modification (ex: google_maps_flutter) Therefore, the rules below are temporarily ignored. Any necessary modifications can be applied in a later PR. flutter/packages#4060 - unnecessary_null_comparison flutter/packages#4067 - unawaited_futures flutter/packages#5717 - dangling_library_doc_comments - no_literal_bool_comparisons - unnecessary_library_directive - use_colored_box - use_enums - use_string_in_part_of_directives
swift-kim
reviewed
Mar 7, 2024
packages/messageport/example/integration_test/messageport_test.dart
Outdated
Show resolved
Hide resolved
swift-kim
approved these changes
Mar 7, 2024
JSUYA
added a commit
to JSUYA/plugins
that referenced
this pull request
Mar 11, 2024
This change is a continuation of this PR. flutter-tizen#675 This change will enable the lint option below and apply the changes. And update the SDK version to apply these lint options. This should be common to all plugins, so apply them together. - unnecessary_null_comparison - unawaited_futures - dangling_library_doc_comments - no_literal_bool_comparisons - unnecessary_library_directive - use_colored_box - use_enums - use_string_in_part_of_directives
JSUYA
added a commit
to JSUYA/plugins
that referenced
this pull request
Mar 12, 2024
This change is a continuation of this PR. flutter-tizen#675 This change will enable the lint option below and apply the changes. And update the SDK version to apply these lint options. This should be common to all plugins, so apply them together. - unnecessary_null_comparison - unawaited_futures - dangling_library_doc_comments - no_literal_bool_comparisons - unnecessary_library_directive - use_colored_box - use_enums - use_string_in_part_of_directives
JSUYA
added a commit
to JSUYA/plugins
that referenced
this pull request
Mar 13, 2024
This change is a continuation of this PR. flutter-tizen#675 This change will enable the lint option below and apply the changes. And update the SDK version to apply these lint options. This should be common to all plugins, so apply them together. - unnecessary_null_comparison - unawaited_futures - dangling_library_doc_comments - no_literal_bool_comparisons - unnecessary_library_directive - use_colored_box - use_enums - use_string_in_part_of_directives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages require package upgrade rather than simple modification (ex: google_maps_flutter)
Therefore, the rules below are temporarily ignored.
Any necessary modifications can be applied in a later PR.
flutter/packages#4060
flutter/packages#4067
flutter/packages#5717