expose rtc_session to/from-tag #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
the goal for this PR is to provide everything we need to to an attended transfer, which we're not able to do right now.
The sessions refer method exposes an
optionparameter where we can set thereplaces-headers.Right now we can't access the sessions to_tag and from_tag which are required in the replaces header to do an attended transfer.
For now I would suggest to expose the to_tag and from_tag only.
This would provide the necessary information for an attended transfer and gives us freedom to implement the attended transfer ourself.
Related issues: