Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuchsia] Debugging code for crash. #38518

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

akbiggs
Copy link
Contributor

@akbiggs akbiggs commented Dec 27, 2022

Adds more logging around the matrix check to understand a crash.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@akbiggs akbiggs added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 27, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 27, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 27, 2022

auto label is removed for flutter/engine, pr: 38518, due to - The status or check suite Linux Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@akbiggs akbiggs added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 27, 2022
@auto-submit auto-submit bot merged commit 10ce8cd into flutter:main Dec 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 27, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 27, 2022
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Dec 27, 2022
…e#38518) (#117697)

Commit: 95a184dcfd89accc93616632fd7fed26af613c8d
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 28, 2022
* c956121 Revert "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117647)

* 0dc9739 6e6a6538f Roll Skia from 2b6d44eb650b to 34708fefacd0 (1 revision) (flutter/engine#38521) (flutter/flutter#117694)

* 95a184d 10ce8cd38 [fuchsia] Debugging code for crash. (flutter/engine#38518) (flutter/flutter#117697)

* a89d135 afe49825e Roll Skia from 34708fefacd0 to 1a93cfdae2fd (1 revision) (flutter/engine#38522) (flutter/flutter#117699)

* 0ddfa72 6128780f1 Roll Dart SDK from 742e1dc3e17f to 68d8b0f58be7 (1 revision) (flutter/engine#38523) (flutter/flutter#117701)

* 4e08ebb 8294e2693 Roll Skia from 1a93cfdae2fd to c5c0387b3399 (2 revisions) (flutter/engine#38524) (flutter/flutter#117702)

* d108c91 bfecc4b18 Roll Dart SDK from 68d8b0f58be7 to 5a173adb22ed (1 revision) (flutter/engine#38525) (flutter/flutter#117707)

* 2864acc 2d431852d Roll Skia from c5c0387b3399 to 656bb22387ac (1 revision) (flutter/engine#38526) (flutter/flutter#117711)

* 6f8d176 74ef2cbc8 Roll Fuchsia Linux SDK from iQT5jpUhipvetxSiH... to yX7ot9Un0bpYQ-XX7... (flutter/engine#38527) (flutter/flutter#117713)

* eda7aab dc6670f7b Roll Dart SDK from 5a173adb22ed to 2541cf36607f (1 revision) (flutter/engine#38528) (flutter/flutter#117715)

* 2223235 8d4546d5b Roll Skia from 656bb22387ac to 913271ba5cbb (2 revisions) (flutter/engine#38529) (flutter/flutter#117719)

* f24df97 3bb936567 Roll Skia from 913271ba5cbb to f78bb848bbe1 (2 revisions) (flutter/engine#38531) (flutter/flutter#117721)

* 17482fd 9e63c1ae1 Roll Fuchsia Mac SDK from c1-ICa-ToxzhYLG7F... to jV7nfgH1Tb3Lw0w_S... (flutter/engine#38532) (flutter/flutter#117731)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Dec 28, 2022
* fe3e93e eb8e52c59 Roll Fuchsia Mac SDK from QOdpfMkM_LcPon_zm... to ozbhYRHpQKfnPwJdh... (flutter/engine#38505) (flutter/flutter#117658)

* 41d1911 becee173e Roll Skia from 7442335dce20 to eeec7a127312 (1 revision) (flutter/engine#38506) (flutter/flutter#117662)

* d15db15 84043c672 Roll Skia from eeec7a127312 to 7fe57dac0702 (1 revision) (flutter/engine#38508) (flutter/flutter#117665)

* 4cce45f 06b2eff9d Roll Dart SDK from 6340d946feac to 494e4d4bf58d (1 revision) (flutter/engine#38509) (flutter/flutter#117667)

* d947687 893e48763 Roll Skia from 7fe57dac0702 to 8099f53e7a43 (1 revision) (flutter/engine#38510) (flutter/flutter#117668)

* a7cc010 dbb5a5739 Roll Fuchsia Mac SDK from ozbhYRHpQKfnPwJdh... to HHADjSDGmZSkODScd... (flutter/engine#38511) (flutter/flutter#117669)

* c3f0c13 dcde1faa8 Roll Skia from 8099f53e7a43 to 789552988917 (1 revision) (flutter/engine#38512) (flutter/flutter#117672)

* 91c3f80 790604a09 Roll Skia from 789552988917 to 6abfcf819da1 (2 revisions) (flutter/engine#38513) (flutter/flutter#117674)

* bf2701d 9d69a91bb Roll Dart SDK from 494e4d4bf58d to 742e1dc3e17f (1 revision) (flutter/engine#38514) (flutter/flutter#117681)

* 00e9cf1 e11cb24 Roll Flutter from e766ad0 to ae292cc (6 revisions) (#6885) (flutter/flutter#117682)

* 5538fa1 c54228b5c Roll Skia from 6abfcf819da1 to 4f64211cd741 (1 revision) (flutter/engine#38515) (flutter/flutter#117684)

* 1c273fb 27ebaec7d Roll Skia from 4f64211cd741 to 3939e68c4b4d (2 revisions) (flutter/engine#38517) (flutter/flutter#117686)

* f11fbba [macOS] Fix the `run_debug_test_macos` on arm64 (flutter/flutter#117250)

* d7abc0b a53f1e983 Roll Skia from 3939e68c4b4d to 2b6d44eb650b (2 revisions) (flutter/engine#38519) (flutter/flutter#117689)

* 894ea20 e049bbf41 Roll Fuchsia Mac SDK from HHADjSDGmZSkODScd... to c1-ICa-ToxzhYLG7F... (flutter/engine#38520) (flutter/flutter#117690)

* c956121 Revert "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117647)

* 0dc9739 6e6a6538f Roll Skia from 2b6d44eb650b to 34708fefacd0 (1 revision) (flutter/engine#38521) (flutter/flutter#117694)

* 95a184d 10ce8cd38 [fuchsia] Debugging code for crash. (flutter/engine#38518) (flutter/flutter#117697)

* a89d135 afe49825e Roll Skia from 34708fefacd0 to 1a93cfdae2fd (1 revision) (flutter/engine#38522) (flutter/flutter#117699)

* 0ddfa72 6128780f1 Roll Dart SDK from 742e1dc3e17f to 68d8b0f58be7 (1 revision) (flutter/engine#38523) (flutter/flutter#117701)

* 4e08ebb 8294e2693 Roll Skia from 1a93cfdae2fd to c5c0387b3399 (2 revisions) (flutter/engine#38524) (flutter/flutter#117702)

* d108c91 bfecc4b18 Roll Dart SDK from 68d8b0f58be7 to 5a173adb22ed (1 revision) (flutter/engine#38525) (flutter/flutter#117707)

* 2864acc 2d431852d Roll Skia from c5c0387b3399 to 656bb22387ac (1 revision) (flutter/engine#38526) (flutter/flutter#117711)

* 6f8d176 74ef2cbc8 Roll Fuchsia Linux SDK from iQT5jpUhipvetxSiH... to yX7ot9Un0bpYQ-XX7... (flutter/engine#38527) (flutter/flutter#117713)

* eda7aab dc6670f7b Roll Dart SDK from 5a173adb22ed to 2541cf36607f (1 revision) (flutter/engine#38528) (flutter/flutter#117715)

* 2223235 8d4546d5b Roll Skia from 656bb22387ac to 913271ba5cbb (2 revisions) (flutter/engine#38529) (flutter/flutter#117719)

* f24df97 3bb936567 Roll Skia from 913271ba5cbb to f78bb848bbe1 (2 revisions) (flutter/engine#38531) (flutter/flutter#117721)

* 17482fd 9e63c1ae1 Roll Fuchsia Mac SDK from c1-ICa-ToxzhYLG7F... to jV7nfgH1Tb3Lw0w_S... (flutter/engine#38532) (flutter/flutter#117731)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
* fe3e93e eb8e52c59 Roll Fuchsia Mac SDK from QOdpfMkM_LcPon_zm... to ozbhYRHpQKfnPwJdh... (flutter/engine#38505) (flutter/flutter#117658)

* 41d1911 becee173e Roll Skia from 7442335dce20 to eeec7a127312 (1 revision) (flutter/engine#38506) (flutter/flutter#117662)

* d15db15 84043c672 Roll Skia from eeec7a127312 to 7fe57dac0702 (1 revision) (flutter/engine#38508) (flutter/flutter#117665)

* 4cce45f 06b2eff9d Roll Dart SDK from 6340d946feac to 494e4d4bf58d (1 revision) (flutter/engine#38509) (flutter/flutter#117667)

* d947687 893e48763 Roll Skia from 7fe57dac0702 to 8099f53e7a43 (1 revision) (flutter/engine#38510) (flutter/flutter#117668)

* a7cc010 dbb5a5739 Roll Fuchsia Mac SDK from ozbhYRHpQKfnPwJdh... to HHADjSDGmZSkODScd... (flutter/engine#38511) (flutter/flutter#117669)

* c3f0c13 dcde1faa8 Roll Skia from 8099f53e7a43 to 789552988917 (1 revision) (flutter/engine#38512) (flutter/flutter#117672)

* 91c3f80 790604a09 Roll Skia from 789552988917 to 6abfcf819da1 (2 revisions) (flutter/engine#38513) (flutter/flutter#117674)

* bf2701d 9d69a91bb Roll Dart SDK from 494e4d4bf58d to 742e1dc3e17f (1 revision) (flutter/engine#38514) (flutter/flutter#117681)

* 00e9cf1 e11cb24 Roll Flutter from e766ad0 to ae292cc (6 revisions) (flutter#6885) (flutter/flutter#117682)

* 5538fa1 c54228b5c Roll Skia from 6abfcf819da1 to 4f64211cd741 (1 revision) (flutter/engine#38515) (flutter/flutter#117684)

* 1c273fb 27ebaec7d Roll Skia from 4f64211cd741 to 3939e68c4b4d (2 revisions) (flutter/engine#38517) (flutter/flutter#117686)

* f11fbba [macOS] Fix the `run_debug_test_macos` on arm64 (flutter/flutter#117250)

* d7abc0b a53f1e983 Roll Skia from 3939e68c4b4d to 2b6d44eb650b (2 revisions) (flutter/engine#38519) (flutter/flutter#117689)

* 894ea20 e049bbf41 Roll Fuchsia Mac SDK from HHADjSDGmZSkODScd... to c1-ICa-ToxzhYLG7F... (flutter/engine#38520) (flutter/flutter#117690)

* c956121 Revert "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117647)

* 0dc9739 6e6a6538f Roll Skia from 2b6d44eb650b to 34708fefacd0 (1 revision) (flutter/engine#38521) (flutter/flutter#117694)

* 95a184d 10ce8cd38 [fuchsia] Debugging code for crash. (flutter/engine#38518) (flutter/flutter#117697)

* a89d135 afe49825e Roll Skia from 34708fefacd0 to 1a93cfdae2fd (1 revision) (flutter/engine#38522) (flutter/flutter#117699)

* 0ddfa72 6128780f1 Roll Dart SDK from 742e1dc3e17f to 68d8b0f58be7 (1 revision) (flutter/engine#38523) (flutter/flutter#117701)

* 4e08ebb 8294e2693 Roll Skia from 1a93cfdae2fd to c5c0387b3399 (2 revisions) (flutter/engine#38524) (flutter/flutter#117702)

* d108c91 bfecc4b18 Roll Dart SDK from 68d8b0f58be7 to 5a173adb22ed (1 revision) (flutter/engine#38525) (flutter/flutter#117707)

* 2864acc 2d431852d Roll Skia from c5c0387b3399 to 656bb22387ac (1 revision) (flutter/engine#38526) (flutter/flutter#117711)

* 6f8d176 74ef2cbc8 Roll Fuchsia Linux SDK from iQT5jpUhipvetxSiH... to yX7ot9Un0bpYQ-XX7... (flutter/engine#38527) (flutter/flutter#117713)

* eda7aab dc6670f7b Roll Dart SDK from 5a173adb22ed to 2541cf36607f (1 revision) (flutter/engine#38528) (flutter/flutter#117715)

* 2223235 8d4546d5b Roll Skia from 656bb22387ac to 913271ba5cbb (2 revisions) (flutter/engine#38529) (flutter/flutter#117719)

* f24df97 3bb936567 Roll Skia from 913271ba5cbb to f78bb848bbe1 (2 revisions) (flutter/engine#38531) (flutter/flutter#117721)

* 17482fd 9e63c1ae1 Roll Fuchsia Mac SDK from c1-ICa-ToxzhYLG7F... to jV7nfgH1Tb3Lw0w_S... (flutter/engine#38532) (flutter/flutter#117731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-fuchsia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants