[iOS][A11Y] fix hittest with non-SemanticsObject #44014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangyujin
reviewed
Jul 26, 2023
| @@ -573,7 +578,13 @@ - (SemanticsObject*)search:(CGPoint)point { | |||
| // IOS 16. Overrides this method to focus the first eligiable semantics | |||
| // object in hit test order. | |||
| - (id)_accessibilityHitTest:(CGPoint)point withEvent:(UIEvent*)event { | |||
| return [self search:point]; | |||
| id hittest = [self search:point]; | |||
| if (hittest != self) { | |||
There was a problem hiding this comment.
can we just check if hittest is a semanticObject here?
cyanglaz
force-pushed
the
platform_view_npe
branch
from
8898a31
to
8a1fb47
Compare
stuartmorgan
requested changes
Jul 31, 2023
| if (![hittest isKindOfClass:[SemanticsObject class]]) { | ||
| // If hittest result is not a SemanticsObject (e.g. PlatformView), | ||
| // call the default hittest method to find the hittest result inside the "hittest". | ||
| return [(NSObject*)hittest _accessibilityHitTest:point withEvent:event]; |
There was a problem hiding this comment.
This is not viable, unfortunately.
If we can't implement this method without needing to make a call like this, we'll need to remove the method entirely and find a different workaround for the initial problem it was added to address.
added 2 commits
August 1, 2023 11:09
cyanglaz
force-pushed
the
platform_view_npe
branch
from
8a1fb47
to
c1d3fd0
Compare
|
@stuartmorgan I overthought the problem. The fix is actually a lot simpler than what I had. PTAL |
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 2, 2023
…131790) flutter/engine@d6b962d...9304c00 2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from d29f946d6180 to 01ee134bb223 (1 revision) (flutter/engine#44269) 2023-08-02 ychris@google.com [iOS][A11Y] fix hittest with non-SemanticsObject (flutter/engine#44014) 2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from d61a50c155bd to d29f946d6180 (1 revision) (flutter/engine#44267) 2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 6009cc6d7d80 to 514c66ce0471 (2 revisions) (flutter/engine#44268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Aug 3, 2023
PlatformViewSemanticsContainer did not implement the nativeAccessibility method, leads to a nil object being returned. Fixes flutter/flutter#131014 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
Cherry-pick #44014 Fixes flutter/flutter#131885 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
PlatformViewSemanticsContainer did not implement the nativeAccessibility method, leads to a nil object being returned. Fixes flutter/flutter#131014 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlatformViewSemanticsContainer did not implement the nativeAccessibility method, leads to a nil object being returned.
Fixes flutter/flutter#131014
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.