Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll third_party/freetype2 from 3bea27612 to af4c2d86d (2 revisions) #52689

Merged
merged 1 commit into from
May 10, 2024

Conversation

bc-lee
Copy link
Contributor

@bc-lee bc-lee commented May 8, 2024

https://flutter.googlesource.com/third_party/freetype2/+log/3bea27612..af4c2d86d

$ git log --format="%ad %ae %s" --date=short 3bea27612..af4c2d86d
2024-05-07 daniel.l@hpcnt.com Fix macro redefinition warning in macOS
2023-05-04 het@google.com Add support for woff and woff2 fonts

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

https://flutter.googlesource.com/third_party/freetype2/+log/3bea27612..af4c2d86d

$ git log --format="%ad %ae %s" --date=short 3bea27612..af4c2d86d
2024-05-07 daniel.l@hpcnt.com Fix macro redefinition warning in macOS
2023-05-04 het@google.com Add support for woff and woff2 fonts
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024
Copy link
Contributor

auto-submit bot commented May 9, 2024

auto label is removed for flutter/engine/52689, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@bc-lee
Copy link
Contributor Author

bc-lee commented May 9, 2024

It seems that this PR cannot be merged because I don't have enough reviewer's approval. @jason-simmons, could you recommend someone to review this PR? Thanks!

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024
@bc-lee
Copy link
Contributor Author

bc-lee commented May 10, 2024

Manual merge is required because the autosubmit bot is broken: flutter/flutter#148092
Could someone please merge this PR? Thanks!

@chinmaygarde chinmaygarde merged commit c30e90d into flutter:main May 10, 2024
36 checks passed
@bc-lee bc-lee deleted the feature/roll-freetype2 branch May 10, 2024 17:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 10, 2024
…148147)

flutter/engine@d4f705c...ba8e0d3

2024-05-10 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Clip before applying ColorFilter so it doesn't filter beyond child bounds (flutter/engine#52704)
2024-05-10 magder@google.com Migrate FlutterView, FlutterPlatformViews, FlutterOverlayView to ARC (flutter/engine#52535)
2024-05-10 matanlurey@users.noreply.github.com Infer `--rbe` based on the existence of `//flutter/build/rbe` (flutter/engine#52700)
2024-05-10 jonahwilliams@google.com [Impeller] Disable AHB swapchain. (flutter/engine#52713)
2024-05-10 skia-flutter-autoroll@skia.org Roll Skia from c7cd1e9690d1 to 11d892ce49b6 (25 revisions) (flutter/engine#52712)
2024-05-10 chinmaygarde@google.com [Impeller] Document how to do basic rendering in Impeller. (flutter/engine#52703)
2024-05-10 30870216+gaaclarke@users.noreply.github.com [impeller] adds experimental canvas docstring (flutter/engine#52710)
2024-05-10 daniel.l@hpcnt.com Roll third_party/freetype2 from 3bea27612 to af4c2d86d (2 revisions) (flutter/engine#52689)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants