Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rfw] Restore RFW to 100% coverage after ButtonBar update #142602

Closed
TahaTesser opened this issue Jan 31, 2024 · 1 comment · Fixed by flutter/packages#6020
Closed

[rfw] Restore RFW to 100% coverage after ButtonBar update #142602

TahaTesser opened this issue Jan 31, 2024 · 1 comment · Fixed by flutter/packages#6020
Assignees
@TahaTesser
Labels
p: rfw Remote Flutter Widgets package package flutter/packages repository. See also p: labels. r: fixed Issue is closed as already fixed in a newer version team-ecosystem Owned by Ecosystem team

Comments

@TahaTesser
Copy link
Member

TahaTesser commented Jan 31, 2024 •
edited
Loading

Use case

flutter/packages#5807 merged result into a 99.9% coverage. See flutter/packages#5807 (comment)

Similar to flutter/packages#4355

Proposal

Restore rfw coverage to 100%
@TahaTesser TahaTesser added in triage Presently being triaged by the triage team package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team p: rfw Remote Flutter Widgets package and removed in triage Presently being triaged by the triage team labels Jan 31, 2024
@TahaTesser TahaTesser self-assigned this Jan 31, 2024
This was referenced Jan 31, 2024
Merged
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this issue Jan 31, 2024
@TahaTesser
[rfw] Restore RFW to 100% coverage after ButtonBar update (#6020)
be0124d 
fixes [[`rfw`]  Restore RFW to 100% coverage after ButtonBar update](flutter/flutter#142602)

### Before

![BEFORE](https://github.com/flutter/packages/assets/48603081/b0671646-d74e-4cc8-a421-23b7130788c8)

### After 

![AFTER](https://github.com/flutter/packages/assets/48603081/c55c7974-fc8f-4c0a-a853-9f4fdf622bac)
@TahaTesser TahaTesser added the r: fixed Issue is closed as already fixed in a newer version label Jan 31, 2024
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TahaTesser TahaTesser

Labels
p: rfw Remote Flutter Widgets package package flutter/packages repository. See also p: labels. r: fixed Issue is closed as already fixed in a newer version team-ecosystem Owned by Ecosystem team
Projects
Nevercode
Status: Done (PR merged)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rfw] Restore RFW to 100% coverage after ButtonBar update TahaTesser/packages
1 participant
@TahaTesser