Make flutter tool enforce >= kotlin 1.7.0, Gradle 7.0.2, and AGP 7.0.0, and Fix test failures blocking androidx upgrade

[gmackall]

PR to pave the way for flutter/engine#53001 to re-land

Summary:

• Enforces use of Kotlin >= 1.7.0 (please see below note)
• Fixes ci failures that prevented the above PR from landing.

Details:

Because it landed initially, we are able to fake the roll in this PR to fix all the tests (see my comment).

Fixes all the tests that failed:

1. module_test failing on multiple platforms (3/9 of the failures).
   Failure is

> Android resource linking failed
   ERROR:/b/s/w/ir/x/t/flutter_module_test.KECMXW/hello/.android/plugins_build_output/device_info/intermediates/merged_res/release/values/values.xml:194: AAPT: error: resource android:attr/lStar not found.

This is a rather unhelpful error message but some folks online suggest that upgrading your compileSdk version fixes this.
These resolve when I remove the dependency on the long discontinued package_info and device_info packages, perhaps because they are transitively pulling in low compileSdk versions? This is unclear to me.

2. module_custom_host_app_name_test was failing for the same reason (another 3/9, or cumulative 6/9).
3. tool_integration_tests_3_4 was a flake 🙂 (7/9)
4. framework_tests_slow needed a newer version of the Kotlin Gradle plugin (the flutter tool tells us this, so I just upgraded as suggested) and it resolved (8/9)
   5.android_preview_tool_integration_tests needed newer AGP and KGP versions. I also refactored the tests, and bumped our error versions, fixing Activate error versions for Gradle, Java, AGP, and KGP #142653.

Note that the bump to KGP is not in line with our policy - we didn't warn for 1.5.0-1.6.x for a release (or at all) before dropping support. But I think it might still be justified:

• The bump to our androidx libraries unblocks ongoing Scribe work, and also includes a fix for a memory leak and a crash on folding phones, among many other bug fixes.
• Gradle doesn't test on half of that range, and so we implicitly can't claim to support it either. More generally, our Java and Kotlin support ranges should probably strictly fall within what Gradle tests.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• I followed the breaking change policy and added Data Driven Fixes where supported.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[gmackall]

Three tests fail in android_preview_tool_integration_tests - two of the failures are fixed by upgrading AGP versions, which we can technically do according to the policy at #140913. But the last one requires a newer version of Kotlin (at least 1.7.10), which would break the policy currently unfortunately

[gmackall]

Bonus, the refactor to the dependency version checker tests should make it very easy for us to set up a suite of tests that range our Gradle/AGP/KGP versions

[flutter-dashboard]

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149204 at sha 0bdbb30

[reidbaker]

I cant tell if this is a staging pr or one that you intend to land. The engine.version is still present that your comment says should not be landed but this is not a draft and this pr set the minimum kotlin version.

If this is the pr to set the error version of kotlin then lets me that the title and first points in the pr description.

[gmackall]

I cant tell if this is a staging pr or one that you intend to land. The engine.version is still present that your comment says should not be landed but this is not a draft and this pr set the minimum kotlin version.

If this is the pr to set the error version of kotlin then lets me that the title and first points in the pr description.

This is the PR I intend to land, I'd left the engine hash to show tests passing. I've reverted that change now though so it's clearer. Also changed title and added summary to description

Sorry for the confusion!