Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] copy flutter_texture_registrar.h header for Windows shell #61098

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

jnschulze
Copy link
Member

Description

Once flutter/engine#19405 has landed we need to ensure that the newly introduced header flutter_texture_registrar.h gets copied on Windows.

Related Issues

#38601
flutter/engine#19405

Tests

I added the following tests:

I created a new plugin with Windows platform support and verified that the respective header file gets copied as expected.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Jul 8, 2020
@jnschulze jnschulze marked this pull request as ready for review September 1, 2020 06:07
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
  • The status or check suite testonly_devicelab_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flutter-dashboard
Copy link

This pull request has not been updated in a while. Please update this pull request to receive results from Gold, or close it.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
  • The status or check suite testonly_devicelab_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jnschulze jnschulze force-pushed the feature/windows-textures branch 2 times, most recently from dec2651 to 57592e6 Compare January 7, 2021 13:56
@jnschulze jnschulze marked this pull request as ready for review January 12, 2021 15:54
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan
Copy link
Contributor

Note that this can't be landed yet, however; see flutter/engine#19405 (comment)

@stuartmorgan
Copy link
Contributor

Waiting on the recipe change that added the new header to the archive to propagate, then for the engine to roll. Once that happens I'll verify that the header is in fact in the archive, then we can land this.

@stuartmorgan
Copy link
Contributor

Waiting on the recipe change that added the new header to the archive to propagate, then for the engine to roll. Once that happens I'll verify that the header is in fact in the archive, then we can land this.

The latest engine archive includes the header. Can you rebase this to the latest master? That should fix the Windows build_test failure (which was due to trying to copy the missing header).

@jnschulze
Copy link
Member Author

Waiting on the recipe change that added the new header to the archive to propagate, then for the engine to roll. Once that happens I'll verify that the header is in fact in the archive, then we can land this.

The latest engine archive includes the header. Can you rebase this to the latest master? That should fix the Windows build_test failure (which was due to trying to copy the missing header).

Done. All checks have passed.

@stuartmorgan stuartmorgan merged commit afe7907 into flutter:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants