-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] copy flutter_texture_registrar.h header for Windows shell #61098
[flutter_tools] copy flutter_texture_registrar.h header for Windows shell #61098
Conversation
f7d800c
to
30c430a
Compare
This pull request is not suitable for automatic merging in its current state.
|
This pull request has not been updated in a while. Please update this pull request to receive results from Gold, or close it. |
This pull request is not suitable for automatic merging in its current state.
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dec2651
to
57592e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note that this can't be landed yet, however; see flutter/engine#19405 (comment) |
Waiting on the recipe change that added the new header to the archive to propagate, then for the engine to roll. Once that happens I'll verify that the header is in fact in the archive, then we can land this. |
The latest engine archive includes the header. Can you rebase this to the latest master? That should fix the |
57592e6
to
52e1f35
Compare
Done. All checks have passed. |
Description
Once flutter/engine#19405 has landed we need to ensure that the newly introduced header
flutter_texture_registrar.h
gets copied on Windows.Related Issues
#38601
flutter/engine#19405
Tests
I added the following tests:
I created a new plugin with Windows platform support and verified that the respective header file gets copied as expected.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].