-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shared_preferences] Remove Android lint baseline #3707
Merged
auto-submit
merged 1 commit into
flutter:main
from
stuartmorgan:shared-preferences-android-warnings
Apr 14, 2023
Merged
[shared_preferences] Remove Android lint baseline #3707
auto-submit
merged 1 commit into
flutter:main
from
stuartmorgan:shared-preferences-android-warnings
Apr 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the issues in the baseline file were stale, so it can just be removed. Part of flutter/flutter#88011
stuartmorgan
added
override: no versioning needed
Override the check requiring version bumps for most changes
override: no changelog needed
Override the check requiring CHANGELOG updates for most changes
labels
Apr 13, 2023
Overrides: lint settings are dev-only. |
15 tasks
tarrinneal
approved these changes
Apr 14, 2023
tarrinneal
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Apr 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 14, 2023
flutter/packages@d01f4ea...e4ec155 2023-04-14 stuartmorgan@google.com [shared_preferences] Remove Android lint baseline (flutter/packages#3707) 2023-04-13 37607224+AmanNegi@users.noreply.github.com [shared_preferences] Ports SharedPreferencesAndroid to Pigeon (flutter/packages#3321) 2023-04-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix Android lint warnings (flutter/packages#3675) 2023-04-13 gautier.bayzelon@gmail.com [go_router_builder] Use only one .where() (flutter/packages#3698) 2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter from 3b4b149 to be45eb2 (21 revisions) (flutter/packages#3701) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
flutter/packages@d01f4ea...e4ec155 2023-04-14 stuartmorgan@google.com [shared_preferences] Remove Android lint baseline (flutter/packages#3707) 2023-04-13 37607224+AmanNegi@users.noreply.github.com [shared_preferences] Ports SharedPreferencesAndroid to Pigeon (flutter/packages#3321) 2023-04-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix Android lint warnings (flutter/packages#3675) 2023-04-13 gautier.bayzelon@gmail.com [go_router_builder] Use only one .where() (flutter/packages#3698) 2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter from 3b4b149 to be45eb2 (21 revisions) (flutter/packages#3701) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[shared_preferences] Remove Android lint baseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
override: no changelog needed
Override the check requiring CHANGELOG updates for most changes
override: no versioning needed
Override the check requiring version bumps for most changes
p: shared_preferences
platform-android
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the issues in the baseline file were stale, so it can just be removed.
Part of flutter/flutter#88011
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).