[camera_android] Fix Android lint warnings

[bparrishMines]

Removes the lint-baseline.xml file, and fixes all issues.

The KotlinPropertyAccess doesn't seem to work well with generics. For example,

class CameraFeature<T> {
  T getValue();
}

class ExposureFeature extends CameraFeature<Exposure> {
  @Override
  Exposure getValue() {
    ...
  }
}

The ExposureFeature.getValue causes the lint warning. I went ahead and suppressed this for all CameraFeatures.

I also added @Nonnull or @Nullable to some private fields that weren't required. This helped deduce whether a value was always nonnull or not.

Part of flutter/flutter#88011

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[bparrishMines]

min version is 21 already

[bparrishMines]

Went through https://developer.android.com/reference/android/hardware/camera2/CameraCharacteristics to verify which could or could not be nullable.

[camsim99]

The changes seem reasonable! Just left one question about a deprecation warning suppression

[camsim99]

Nice catch!

[camsim99]

Do we need this if it is deprecated?

[bparrishMines]

It's deprecated, but there was a warning for missing a case:

/Users/bmparr/Development/packages/packages/camera/camera_android/android/src/main/java/io/flutter/plugins/camera/features/sensororientation/DeviceOrientationManager.java:255: Error: Switch statement on an int with known associated constant missing case Configuration.ORIENTATION_SQUARE [SwitchIntDef]
    switch (orientation) {
    ~~~~~~

The alternative was to suppress the warning that not all of the cases were handled. I thought this would be worse since it wouldn't notify us when a new one was added.

[stuartmorgan]

I also added @Nonnull or @Nullable to some private fields that weren't required. This helped deduce whether a value was always nonnull or not.

Yeah, I've run into that too; I wish we could make it a warning everywhere just for our own benefit.

[stuartmorgan]

Interesting, it doesn't matter where this goes? I would have thought it would need be next to the type (@Override public @NonNull AutoFocusFeature).

[bparrishMines]

I've didn't even know you could put it after the public modifier. But, yea this worked for me. I assumed the same pattern as Dart.