[webview_flutter] Add listener for content offset (Platform Interface) #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
TheVinhLuong
force-pushed
the
webview-scroll-listener-interface
branch
from
d157443 to
b243d07
Compare
TheVinhLuong
force-pushed
the
webview-scroll-listener-interface
branch
from
b243d07 to
e44d948
Compare
|
Hi @bparrishMines, could you please take a look at this. |
bparrishMines
approved these changes
Nov 28, 2023
bparrishMines
added
the
federated: partial_changes
tarrinneal
approved these changes
Nov 28, 2023
stuartmorgan
added
the
autosubmit
|
In general, we should add |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 29, 2023
flutter/packages@3c05466...e4aaba8 2023-11-28 ian@hixie.ch [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471) 2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483) 2023-11-28 70025277+Nitin-Poojary@users.noreply.github.com [flutter image] Changed image link to use image within package (flutter/packages#5326) 2023-11-28 PROGrand@users.noreply.github.com camera_android: Camera.java pausePreview null check (flutter/packages#5265) 2023-11-28 ltv.luongthevinh@gmail.com [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
flutter#5427) Adds the platform interface implementation for content offset listener This PR is part of a series of PRs that aim to close flutter/flutter#31027. The PR that contains all changes can be found at flutter#3444.
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
flutter/packages@3c05466...e4aaba8 2023-11-28 ian@hixie.ch [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471) 2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483) 2023-11-28 70025277+Nitin-Poojary@users.noreply.github.com [flutter image] Changed image link to use image within package (flutter/packages#5326) 2023-11-28 PROGrand@users.noreply.github.com camera_android: Camera.java pausePreview null check (flutter/packages#5265) 2023-11-28 ltv.luongthevinh@gmail.com [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
flutter#5427) Adds the platform interface implementation for content offset listener This PR is part of a series of PRs that aim to close flutter/flutter#31027. The PR that contains all changes can be found at flutter#3444.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the platform interface implementation for content offset listener
This PR is part of a series of PRs that aim to close flutter/flutter#31027.
The PR that contains all changes can be found at #3444.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.