Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file_selector] Fixed typo in code comment 'pltaform' -> 'platform' #5479

Closed
wants to merge 1 commit into from

Conversation

BrutalCoding
Copy link

@BrutalCoding BrutalCoding commented Nov 26, 2023

Found & fixed a typo while I was going through the code.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This will need to complete the missing steps from the checklist that are causing repo_checks to fail in the CI before it can be fully reviewed.

@stuartmorgan
Copy link
Contributor

@BrutalCoding Are you still planning on updating this PR as mentioned in the comment above?

@BrutalCoding
Copy link
Author

@BrutalCoding Are you still planning on updating this PR as mentioned in the comment above?

@stuartmorgan Apologies, I lost track of this issue.

Do you reckon that this PR is exempt from versioning? If so, we should apply the "override: no versioning needed" label if I'm not mistaken.

I'll try to spend some time on this PR somewhere this weekend. Seems like this PR is outdated by now so I'd prob start with updating/rebasing > checking ci logs > fix issues/tick off boxes > wait for feedback.

@stuartmorgan
Copy link
Contributor

Do you reckon that this PR is exempt from versioning?

Which of the exemptions would it fall under?

@stuartmorgan
Copy link
Contributor

Closing in favor of #6027; thanks for flagging the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants