[go_router] fix(docs): typo in example extra_codec.dart #5570
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
LGTM, can you write a small test for this? in the packages/packages/go_router/example/test/extra_codec_test.dart, just create a MyExtraCodec and try to decode a malformed input and expect it to throw with the message. I think it is easier than to ask for not test exception
chunhtai
added
override: no versioning needed
|
No Change log and version needed. Reason: this example is not visible in pub dev and can only be seen in github repo, so I think it won't change anything if we bump a version. |
chunhtai
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages/5570, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
hangyujin
added
the
autosubmit
flutter/packages@1151191...3f2e16b 2023-12-15 magder@google.com Swap some iOS package CODEOWNERS (flutter/packages#5667) 2023-12-14 ychris@google.com [in_app_purchase_storekit]add storekit configuration to the example app (flutter/packages#5411) 2023-12-14 50643541+Mairramer@users.noreply.github.com [camera_platform_interface] Adds support for setting the image file format (flutter/packages#5593) 2023-12-14 34871572+gmackall@users.noreply.github.com [path_provider_android] Re-enable getExternalStorageDirectories test (flutter/packages#5668) 2023-12-14 ndelanou@users.noreply.github.com [go_router] fix(docs): typo in example extra_codec.dart (flutter/packages#5570) 2023-12-14 stuartmorgan@google.com [ios_platform_images] Adopt code-excerpts (flutter/packages#5682) 2023-12-14 me@nils.re [camera] Fix typo "intialize" in doc comments (flutter/packages#4949) 2023-12-14 engine-flutter-autoroll@skia.org Roll Flutter from 11a9cb7 to a51e33a (30 revisions) (flutter/packages#5680) 2023-12-14 katelovett@google.com [two_dimensional_scrollables] Post 3.16 stable tech debt clean up (flutter/packages#5671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Replace
```
throw FormatException('Unable tp parse input: $input');
```
by
```
throw FormatException('Unable to parse input: $input');
```
Replace
by
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.