[pointer_interceptor_web] migrates pointer interceptor to package:web #5673
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…ackage_web' into migrate_pointer_interceptor_to_package_web
|
@balvinderz just saw this! Thanks for the fix, I added some of your code to my PR: I'm trying very hard that your icon shows up in the commit log! 🤞 |
## Changes: * Updates the web implementation of the `pointer_interceptor` to `package:web`, and the latest `HtmlElementView` APIs available on Flutter. * Resolves a timing issue in integration tests by waiting a few frames before doing any assertions from the DOM of a Flutter Web app, that should fix flutter rolls. ## Issues: * Fixes flutter/flutter#140834 * Fixes flutter/flutter#139753 * Closes #5673 (Credit to @balvinderz!) ## Tests * Tested manually. All integration tests pass locally. --- Co-authored-by: balvinderz <balvindersi2@gmail.com>
|
Yeah, that's what I mean! 
|
## Changes: * Updates the web implementation of the `pointer_interceptor` to `package:web`, and the latest `HtmlElementView` APIs available on Flutter. * Resolves a timing issue in integration tests by waiting a few frames before doing any assertions from the DOM of a Flutter Web app, that should fix flutter rolls. ## Issues: * Fixes flutter/flutter#140834 * Fixes flutter/flutter#139753 * Closes flutter#5673 (Credit to @balvinderz!) ## Tests * Tested manually. All integration tests pass locally. --- Co-authored-by: balvinderz <balvindersi2@gmail.com>
Migrates pointer_interceptor_web from dart:html to package:web and Updates minimum supported SDK version to Flutter 3.16.0/Dart 3.2.0
Removed isSemantics available check also because we are on flutter 3
flutter/flutter#139753
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.