Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google_sign_in] Correct clearAuthCache declarations #5693

Merged
merged 3 commits into from
Jan 3, 2024
Merged

[google_sign_in] Correct clearAuthCache declarations #5693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06b88a6
[google_sign_in] Correct clearAuthCache declarations
stuartmorgan Dec 15, 2023
9550ad5
Merge branch 'main' into sign-in-impl-nullability-cleanup
stuartmorgan Jan 3, 2024
b473e65
Revert platform interface
stuartmorgan Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/google_sign_in/google_sign_in_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT
## 6.1.21

* Updates `clearAuthCache` override to match base class declaration.
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.

## 6.1.20
Expand Down
6 changes: 2 additions & 4 deletions packages/google_sign_in/google_sign_in_android/lib/google_sign_in_android.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,8 @@ class GoogleSignInAndroid extends GoogleSignInPlatform {
}

@override
Future<void> clearAuthCache({String? token}) {
// The token is not acutally nullable; see
// https://github.com/flutter/flutter/issues/129717
return _api.clearAuthCache(token!);
Future<void> clearAuthCache({required String token}) {
return _api.clearAuthCache(token);
}

@override
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_sign_in_android
description: Android implementation of the google_sign_in plugin.
repository: https://github.com/flutter/packages/tree/main/packages/google_sign_in/google_sign_in_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
version: 6.1.20
version: 6.1.21

environment:
sdk: ">=3.0.0 <4.0.0"
Expand Down
4 changes: 4 additions & 0 deletions packages/google_sign_in/google_sign_in_ios/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 5.7.2

* Updates `clearAuthCache` override to match base class declaration.

## 5.7.1

* Changes `pigeon` to a dev dependency.
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in_ios/lib/google_sign_in_ios.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class GoogleSignInIOS extends GoogleSignInPlatform {
}

@override
Future<void> clearAuthCache({String? token}) async {
Future<void> clearAuthCache({required String token}) async {
// There's nothing to be done here on iOS since the expired/invalid
// tokens are refreshed automatically by getTokens.
}
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in_ios/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_sign_in_ios
description: iOS implementation of the google_sign_in plugin.
repository: https://github.com/flutter/packages/tree/main/packages/google_sign_in/google_sign_in_ios
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
version: 5.7.1
version: 5.7.2

environment:
sdk: ">=3.2.0 <4.0.0"
Expand Down