[webview_platform_interface] Adds WebResourceRequest to HttpResponseError #5790
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bparrishMines
changed the title
| test( | ||
| 'ensures webview_flutter_platform_interface.dart exports classes in types directory', | ||
| () { | ||
| // ignore: unnecessary_statements |
There was a problem hiding this comment.
You could make this test its own file (e.g., webview_flutter_platform_interface_export_tests.dart), and then make this a file-level ignore, since a file that only tests exports wouldn't need to worry about losing lint coverage.
There was a problem hiding this comment.
Good suggestion. I will also make a mental note to do this for the webview_flutter package as well.
...s/webview_flutter/webview_flutter_platform_interface/lib/src/types/web_resource_request.dart
Show resolved
Hide resolved
bparrishMines
added
the
autosubmit
flutter/packages@e4cbf23...841fe90 2024-01-22 katelovett@google.com [two_dimensional_scrollables] Fix TableSpanDecoration rects when axes are reversed (flutter/packages#5916) 2024-01-22 43054281+camsim99@users.noreply.github.com [most on Android] Bump compile SDK version to 34 (flutter/packages#5783) 2024-01-22 dshukertjr@gmail.com [url_launcher]: Fix a grammar error in the comments of launchUrl method (flutter/packages#5919) 2024-01-22 10687576+bparrishMines@users.noreply.github.com [webview_platform_interface] Adds WebResourceRequest to HttpResponseError (flutter/packages#5790) 2024-01-22 43054281+camsim99@users.noreply.github.com [camerax] Update `Activity` references when `ActivityAware` lifecycle methods called (flutter/packages#5784) 2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter from 5dea6b9 to 3ee8ff2 (9 revisions) (flutter/packages#5955) 2024-01-22 stuartmorgan@google.com [espresso] Replace deprecated `getObservatoryUri` (flutter/packages#5788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…rror (flutter#5790) This is a copy of flutter#4025 with updates from PR comments. The original didn't allow maintainers to update the code, so I create this branch.
This is a copy of #4025 with updates from PR comments. The original didn't allow maintainers to update the code, so I create this branch.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.