[in_app_purchase] fix skerror nullability #6139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
requested changes
Feb 15, 2024
| @@ -1,3 +1,7 @@ | |||
| ## 0.3.10+1 | |||
There was a problem hiding this comment.
This should be 0.3.11. The +N is reserved for changes that don't change the behavior.
| @@ -2,7 +2,7 @@ name: in_app_purchase_storekit | |||
| description: An implementation for the iOS and macOS platforms of the Flutter `in_app_purchase` plugin. This uses the StoreKit Framework. | |||
| repository: https://github.com/flutter/packages/tree/main/packages/in_app_purchase/in_app_purchase_storekit | |||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22 | |||
| version: 0.3.10 | |||
| version: 0.3.10+1 | |||
LouiseHsu
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
approved these changes
Feb 16, 2024
LouiseHsu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2024
flutter/packages@ef349be...c56c12d 2024-02-16 10687576+bparrishMines@users.noreply.github.com [tool] Add support for using a Kotlin test runner file (flutter/packages#6131) 2024-02-16 louisehsu@google.com [in_app_purchase] fix skerror nullability (flutter/packages#6139) 2024-02-15 jacksongardner@google.com Explicitly pass the web renderer into the tests. (flutter/packages#6140) 2024-02-15 stuartmorgan@google.com [google_sign_in] Clean up pre-Pigeon code (flutter/packages#6141) 2024-02-15 stuartmorgan@google.com [local_auth] Add compatibility with latest `intl` (flutter/packages#6138) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix flutter/flutter#143177
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).