Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize all index.html files to support WASM #7114

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Modernize all index.html files to support WASM #7114

merged 4 commits into from
Jul 17, 2024

Conversation

Rexios80
Copy link
Member

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Rexios80
Copy link
Member Author 

No CHANGELOG change found.
If this PR needs an exemption from the standard policy of listing all changes in the CHANGELOG,
comment in the PR to explain why the PR is exempt, and add (or ask your reviewer to add) the
"override: no changelog needed" label.

Since none of this affects code that consumers actually run when using these packages in their projects, we shouldn't need CHANGELOG entries

@kevmoo
Copy link
Contributor

kevmoo commented Jul 12, 2024 

No CHANGELOG change found.
If this PR needs an exemption from the standard policy of listing all changes in the CHANGELOG,
comment in the PR to explain why the PR is exempt, and add (or ask your reviewer to add) the
"override: no changelog needed" label.

Since none of this affects code that consumers actually run when using these packages in their projects, we shouldn't need CHANGELOG entries

Sure, but there are robots involved here. Read the docs to see what to do in this case. Or ask in Discord...

@Rexios80
Copy link
Member Author

Is that text from the CI failure not the documentation? I guess I forgot to explicitly ask someone to add the override tag. Is there something else I'm missing?

@Rexios80
Copy link
Member Author

Also there might be a bug in flutter_bootstrap.js that's causing integration tests to not report their status and hang forever but I'm not exactly sure what's going on. We're having the same issue in this PR: #7012

@stuartmorgan
Copy link
Contributor

test-exempt: configuration change

CHANGELOG override: mechanical change to example plumbing to bring it up to current standard.

@stuartmorgan stuartmorgan added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jul 15, 2024
@ditman
Copy link
Member

ditman commented Jul 15, 2024

This new bootstrap style + canvaskit are introducing some race conditions that flutter drive is having trouble handling. I'm trying to work on a more permanent solution here, but still haven't figured it out yet:

chunhtai
chunhtai approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for go_router

@ditman
Copy link
Member

ditman commented Jul 17, 2024

Linux_web web_platform_tests should improve a lot by rebasing this PR with main after this PR lands.

@kevmoo
Copy link
Contributor

kevmoo commented Jul 17, 2024

Guessing that remaining failure is UNRELATED. I'll try rerunning.

ditman
ditman approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2024
@auto-submit auto-submit bot merged commit df420f6 into flutter:main Jul 17, 2024
76 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
df420f6 Modernize all index.html files to support WASM (flutter/pac…
d3d562a 
…kages#7114)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
df420f6 Modernize all index.html files to support WASM (flutter/pac…
5e3f157 
…kages#7114)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
Roll Packages from d03b1b4 to c7f0526 (8 revisions) (#151971)
9d76e12 
flutter/packages@d03b1b4...c7f0526

2024-07-18 737941+loic-sharma@users.noreply.github.com [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples (flutter/packages#7145)
2024-07-17 rexios80@me.com Modernize all `index.html` files to support WASM (flutter/packages#7114)
2024-07-17 louisehsu@google.com [in_app_purchase_storekit] Migrate InAppPurchasePluginTests.m to. Swift (flutter/packages#7105)
2024-07-17 ditman@gmail.com [ci] Drive tests with html renderer if CHANNEL is stable. (flutter/packages#7146)
2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7120)
2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7121)
2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7128)
2024-07-17 30872003+misos1@users.noreply.github.com [camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash (flutter/packages#6901)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 25, 2024
Merged
11 tasks
@vbuberen vbuberen mentioned this pull request Aug 6, 2024
Merged
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll @TytaniumDev
Roll Packages from d03b1b4 to c7f0526 (8 revisions) (flutter#151971)
6e1f667 
flutter/packages@d03b1b4...c7f0526

2024-07-18 737941+loic-sharma@users.noreply.github.com [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples (flutter/packages#7145)
2024-07-17 rexios80@me.com Modernize all `index.html` files to support WASM (flutter/packages#7114)
2024-07-17 louisehsu@google.com [in_app_purchase_storekit] Migrate InAppPurchasePluginTests.m to. Swift (flutter/packages#7105)
2024-07-17 ditman@gmail.com [ci] Drive tests with html renderer if CHANNEL is stable. (flutter/packages#7146)
2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7120)
2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7121)
2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7128)
2024-07-17 30872003+misos1@users.noreply.github.com [camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash (flutter/packages#6901)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Packages from d03b1b4 to c7f0526 (8 revisions) (flutter#151971)
1f367fd 
flutter/packages@d03b1b4...c7f0526

2024-07-18 737941+loic-sharma@users.noreply.github.com [flutter_plugin_tools] Allow disabling Swift Package Manager when building examples (flutter/packages#7145)
2024-07-17 rexios80@me.com Modernize all `index.html` files to support WASM (flutter/packages#7114)
2024-07-17 louisehsu@google.com [in_app_purchase_storekit] Migrate InAppPurchasePluginTests.m to. Swift (flutter/packages#7105)
2024-07-17 ditman@gmail.com [ci] Drive tests with html renderer if CHANNEL is stable. (flutter/packages#7146)
2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7120)
2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7121)
2024-07-17 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7128)
2024-07-17 30872003+misos1@users.noreply.github.com [camera_avfoundation] do not append sample buffer when readyForMoreMediaData is NO to avoid crash (flutter/packages#6901)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@ditman ditman ditman approved these changes

@chunhtai chunhtai chunhtai approved these changes

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@stuartmorgan stuartmorgan Awaiting requested review from stuartmorgan stuartmorgan is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@goderbauer goderbauer Awaiting requested review from goderbauer goderbauer is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: animations p: camera p: file_selector p: flutter_markdown p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: pointer_interceptor p: rfw Remote Flutter Widgets p: shared_preferences p: url_launcher p: video_player platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update packages repo web integration test examples index.html files to support WASM
6 participants
@Rexios80 @kevmoo @stuartmorgan @ditman @domesticmouse @chunhtai