This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[tools] Require implementation package README warning #6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that the README in the example of a federated plugin implementation package explains that it is intended as a testbed, not a real example to follow. Updates the existing READMEs accordingly to fix violations of the new check. Fixes flutter/flutter#111904
|
I only updated one README, so that it can be reviewed, and updated as necessary. Once we're happy with the text I'll update the PR to duplicate it into every implementation package. |
stuartmorgan
added
the
override: no changelog needed
stuartmorgan
requested review from
cyanglaz,
hellohuanlin,
jmagman,
camsim99,
GaryQian,
ditman and
tarrinneal
as code owners
github-actions
bot
added
p: camera
p: file_selector
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: quick_actions
p: shared_preferences
p: video_player
p: webview_flutter
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the README in the example of a federated plugin implementation package explains that it is intended as a testbed, not a real example to follow.
Updates the existing READMEs accordingly to fix violations of the new check.
Fixes flutter/flutter#111904
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).