Animation tutorial: create full example apps and use code excerpter #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chalin
force-pushed
the
chalin-animation-tutorial-0130
branch
from
6522056
to
30ba84a
Compare
chalin
commented
Jan 31, 2019
| class ShakeCurve extends Curve { | ||
| @override | ||
| double transform(double t) { | ||
| return math.sin(t * math.PI * 2); |
There was a problem hiding this comment.
Note that the old code still used the Dart 1 math PI constant! (This is why it's good to have automated code extraction :)
|
Ouch, thanks for fixing this! LGTM, although I did not fully review the code — let me know if you expect me to, and/or direct me to the important parts. |
|
There are no major (functional) changes to the code, so we should be good. |
chalin
commented
Jan 31, 2019
| values. | ||
|
|
||
| `LogoApp` widget was changed to encapsulate its own `Tween` objects. |
There was a problem hiding this comment.
Here is the part of the prose where it mismatches with the code. It's not the LogoApp that's impacted, its the AnimatedLogo class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2319
Contributes to #2233, #2279
Staged at https://flutter-io-staging-1.firebaseapp.com/docs/development/ui/animations/tutorial
(The indentation of code excerpts is off in a few cases. I'll file an issue over the code excerpter / code-excerpt renderer tool to address this.)