Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libraries to use in application with common packages #72

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

AlirezaDaryani
Copy link
Contributor

When I need to use this package in my app, it was impossible to upgrade common packages.
for example I want to use package_info_plus: ^3.0.2 in my app but it was impossible because app_review used old versions of that.
Here is updated packages in yaml file:

  package_info_plus: ^3.0.2
  url_launcher: ^6.1.7

@yutae
Copy link

yutae commented Dec 15, 2022

@rodydavis Please check this PR 🙏

@techwn
Copy link

techwn commented Aug 2, 2023

I think you can add your dependencies in your yaml.
Since app_review use package_info_plus: ^3.0.1, you can use any version of package_info_plus between 3.0.1 and 4.0.0.

Copy link
Member

@rodydavis rodydavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doubleo2
Copy link

@rodydavis There are five open PRs all of which are variations of the same thing: updating package_info_plus. It took 18 months for you to review this PR and despite getting your nod of approval, it's still unclear how this gets merged and released.

How do we move this package forward?

@rodydavis
Copy link
Member

Part of the intention of moving the package to Flutter Community would be that I didn't have to block on releases.

That being said, I reviewed the PR and LGTM 👍🏼

Copy link
Member

@rodydavis rodydavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodydavis
Copy link
Member

There are some conflicts that need to be resolved before merging. I’ll watch this and when it is ready I’ll merge and publish

@AlirezaDaryani
Copy link
Contributor Author

The conflict has been fixed, But I'm not sure if it is useful anymore...

@rodydavis rodydavis merged commit 8910827 into fluttercommunity:master Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants