-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: restructured, cleaned, added pub.dev checks #108
Conversation
daadu
commented
Dec 19, 2021
- [deploy_demo]: proper step name, switched to "stable"
- [pr_title]: proper step name
- [deploy_demo]: proper step name, switched to "stable" - [pr_title]: proper step name
@WieFel Will release v0.7.0 after this merge. |
… job - cd: using scripts to install - flutter and dependencies
@WieFel Can you review now. |
@daadu what I find a bit strange is using |
Mainly to make the step faster - check new - 59s vs old - 66s, although the difference is not much, I expected more though! |
I was expecting the 3rd party action to be using caching - for flutter binary - but looks like they don't. May be with our script can add caching to make it faster. |
In my opinion, readability/clarity of the actions would be more important in this case than 5s of quicker execution. |
- removed `install-flutter.sh` and `install-dependencies.sh`
going with your suggestion. makes sense. |
We can try adding caching to current to reduce time or come back to |
@daadu ok! |
I think CI feedback should be fast though - like in about a 1-2m should know things are ok! |
Yeah sure! As long as it is within this limit it is ok |