Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Option to add FloatingActionButton to BackdrawScaffold #21

Merged
merged 5 commits into from
May 27, 2020
Merged

Add Option to add FloatingActionButton to BackdrawScaffold #21

merged 5 commits into from
May 27, 2020

Conversation

felixwortmann
Copy link
Contributor

No description provided.

@WieFel
Copy link
Collaborator

WieFel commented May 22, 2020

Ok for me!
@daadu I don't know whether we should already include the version update and the updated changelog?
I let you handle that...

@daadu
Copy link
Member

daadu commented May 26, 2020 •
edited
Loading

@felixwortmann @WieFel version bump and changelog should not be added in PR.

I have resolved merge conflicts.

Here are my thoughts:

  • floatingActionButtonLocation and floatingActionButtonAnimator should also be added
  • appBarBackgroundColor should be part of planned BackdropAppBar widget BackdropAppBar #6 BackdropAppBar #23

@WieFel What do you think?

@WieFel
Copy link
Collaborator

WieFel commented May 26, 2020

If we merge #23 before this one then the appBarBackgroundColor property could be removed, as it is already handled by BackdropAppBar.
Therefore I was thinking of implementing the app bar before accepting this pull request ;)

@daadu daadu requested review from daadu and WieFel May 26, 2020 15:44
@daadu
Copy link
Member

daadu commented May 26, 2020

@felixwortmann Please do the agreed changes.

@daadu
Copy link
Member

daadu commented May 26, 2020

@felixwortmann One more change:

  • refactor backPanelBackgroundColor -> backLayerBackgroundColor to be consistent with nomenclature.

@daadu daadu added the changes requested Changes requested in PRs label May 27, 2020
@daadu daadu added this to the v1.0 milestone May 27, 2020
@daadu
Copy link
Member

daadu commented May 27, 2020

@felixwortmann Please confirm if you will be working on the changes.

@felixwortmann
Copy link
Contributor Author

@daadu I will implement the changes later today or this week

added FloatingActionButtonLocation
e737280 
added FloatingActionButtonAnimator
removed appBarBackgroundColor
renamed backPandelBackgroundColor to backLayerBackgroundColor
@felixwortmann
Copy link
Contributor Author

@daadu I think this should be it. Can you take a look please?

daadu
daadu approved these changes May 27, 2020
View reviewed changes
lib/backdrop.dart Outdated Show resolved Hide resolved
@daadu
Copy link
Member

daadu commented May 27, 2020

LGTM. @WieFel What do you think?

@WieFel
Copy link
Collaborator

WieFel commented May 27, 2020

Approved!

@daadu daadu merged commit 40b778d into fluttercommunity:master May 27, 2020
@daadu
Copy link
Member

daadu commented May 27, 2020 •
edited
Loading

Congrats @felixwortmann your code have landed to v0.3.1 on pub.dev. Also check yourself in Contributor's Section on README !!

@renovate renovate bot mentioned this pull request May 1, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daadu daadu daadu approved these changes

@WieFel WieFel Awaiting requested review from WieFel

Assignees

@felixwortmann felixwortmann

Labels
changes requested Changes requested in PRs
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@felixwortmann @WieFel @daadu