-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Null safety #86
Null safety #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daadu need your help on some things
Also: should For |
@WieFel Should we merge this to master? Or release "null-saftey" to different version series "v0.6.x". This is until we are supporting "non-null safety" in v0.5.x. Any new fix, will need to be merged with both. Later we can merge them. |
@WieFel Give me your views on it. If the user does not uprgade his project to "null safety", will our package break things? if that is true, then we can merge this to master. |
I just played around with it. I downgraded Flutter to version
(where Thus, by applying null-safe code to master we would force users to upgrade to Flutter |
@daadu In my opinion it requires just additional effort if we maintain a "null-safety" and "non-null-safety" version in two different branches. Those are way more popular than @proninyaroslav what do you think about this? |
@WieFel |
@WieFel @proninyaroslav Ok then, lets release this as @WieFel Can you add that note? |
Added myself. |
LGTM 🎉 |
This fix/feature has landed with v0.6.0 on pub.dev. |
Closes #85