-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to disable the subtitles by default? #648
Comments
I would like to work on this issue |
I have implemented this in #865 |
…rcommunity#648) Introduced `showSubtitlesPerDefault` in `ChewieController` to allow disabling subtitles by default. Updated controls to respect the flag and aligned behavior across platforms. Added documentation. Closes fluttercommunity#648
Hi everyone, I’d like to provide some context regarding my PR (#872) and how it addresses this issue. The goal here was to ensure subtitles can be disabled by default while maintaining the native Chewie experience, including the use of the subtitle toggle button. @stevsimo PR (#865) is a great start, but it takes a different approach by disabling subtitles entirely. This means subtitles can no longer be toggled dynamically using the built-in controls, and any control over subtitles would have to be implemented externally. While this might work in specific use cases, it diverges from the native functionality Chewie is designed to provide. In contrast, my PR introduces a showSubtitlesPerDefault flag: Subtitles are off by default when the flag is set to false (the default value). I’d be happy to discuss this further if there’s additional feedback or suggestions. Looking forward to hearing your thoughts! |
…rcommunity#648) Introduced `showSubtitlesPerDefault` in `ChewieController` to allow disabling subtitles by default. Updated controls to respect the flag and aligned behavior across platforms. Added documentation. Closes fluttercommunity#648
I've added subtitles and they work. I can disable them in the app manually, but is there a way to disable them in the code automatically (ideally as the default option)?
The text was updated successfully, but these errors were encountered: