Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to disable the subtitles by default? #648

Open
JThorvid opened this issue Jun 17, 2022 · 3 comments · May be fixed by #872
Open

Is it possible to disable the subtitles by default? #648

JThorvid opened this issue Jun 17, 2022 · 3 comments · May be fixed by #872

Comments

@JThorvid
Copy link

I've added subtitles and they work. I can disable them in the app manually, but is there a way to disable them in the code automatically (ideally as the default option)?

@PranavMasekar
Copy link

I would like to work on this issue

@stevsimo
Copy link

I have implemented this in #865

floodoo added a commit to floodoo/chewie that referenced this issue Nov 20, 2024
…rcommunity#648)

Introduced `showSubtitlesPerDefault` in `ChewieController` to allow disabling subtitles by default. Updated controls to respect the flag and aligned behavior across platforms. Added documentation.

Closes fluttercommunity#648
@floodoo
Copy link

floodoo commented Nov 20, 2024

Hi everyone,

I’d like to provide some context regarding my PR (#872) and how it addresses this issue. The goal here was to ensure subtitles can be disabled by default while maintaining the native Chewie experience, including the use of the subtitle toggle button.

@stevsimo PR (#865) is a great start, but it takes a different approach by disabling subtitles entirely. This means subtitles can no longer be toggled dynamically using the built-in controls, and any control over subtitles would have to be implemented externally. While this might work in specific use cases, it diverges from the native functionality Chewie is designed to provide.

In contrast, my PR introduces a showSubtitlesPerDefault flag:

Subtitles are off by default when the flag is set to false (the default value).
Users can still dynamically toggle subtitles during playback using the subtitle toggle button, preserving the seamless native experience.
This approach ensures we meet the original request for a default "off" state for subtitles without removing Chewie's built-in functionality.
Additionally, I updated the example video URLs as the current ones were no longer accessible. The new URLs ensure the examples function correctly and provide a better demonstration of the feature.

I’d be happy to discuss this further if there’s additional feedback or suggestions. Looking forward to hearing your thoughts!

floodoo added a commit to floodoo/chewie that referenced this issue Nov 20, 2024
…rcommunity#648)

Introduced `showSubtitlesPerDefault` in `ChewieController` to allow disabling subtitles by default. Updated controls to respect the flag and aligned behavior across platforms. Added documentation.

Closes fluttercommunity#648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants