Allow Chewie controls to be positioned to allow for a larger safe area. #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM so far. There might be a couple of nits, but that's it. Once it passes automated checks, then it'll get merged into master. |
diegotori
requested changes
Oct 19, 2022
|
@jweidner-mbible please re-sync your change with master. Thanks. |
|
@diegotori I just re-synced my change with master. |
|
@diegotori Any idea on when this might get merged into master? :) |
|
@caitlynbell399 rerunning the lint and format CI tasks. If they're green, then they'll look good to me |
|
@jweidner-mbible looks like the CI checks failed. Please address them, or else I won't be able to merge. Thanks. |
|
@diegotori Committed a fix for the issue. Thank you for your help with this :) |
|
LGTM. Merging. |
diegotori
added a commit
that referenced
this pull request
Nov 25, 2022
lg8294
added a commit
to lg8294/chewie
that referenced
this pull request
Jan 3, 2023
* master: Version 1.3.6. Addresses PRs fluttercommunity#676 and fluttercommunity#681. fix default value for minimum safe area Cleaned up the Github Workflows YAML. Fixed remaining Dart Analysis issues after switching to flutter_lints. Example app is now using flutter_lints. Library is now using flutter_lints. Changed documentation as requested Use EdgeInsets.zero Allow Chewie controls to be positioned to allow for a larger safe area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.