Restore Chosen Playback Speed After Seeking #823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegotori
requested changes
Apr 1, 2024
lib/src/progress_bar.dart
Outdated
Comment on lines
62
to
70
| await controller.seekTo(context.calcRelativePosition( | ||
| controller.value.duration, | ||
| globalPosition, | ||
| )); | ||
| // For some reason playback speed gets reset when | ||
| // seeking, so it needs to be restored | ||
| Future.delayed(const Duration(milliseconds: 1000), () { | ||
| controller.setPlaybackSpeed(currentPlaybackSpeed); | ||
| }); |
There was a problem hiding this comment.
Consider combining both async calls, one after the other:
final currentPlaybackSpeed = controller.value.playbackSpeed;
await controller.seekTo(context.calcRelativePosition(
controller.value.duration,
globalPosition,
)).then((_) {
controller.setPlaybackSpeed(currentPlaybackSpeed);
});
|
Thanks, I tried that code, but for some reason the speed resets again. Maybe the 1 second wait is necessary? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When seeking using the progress bar, the playback speed is reset to 1.
I've changed the code to restore the playback speed after seeking to the new position in the progress bar.