Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced print in production with developer log #537

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Replaced print in production with developer log #537

merged 1 commit into from
Oct 12, 2021

Conversation

adityathakurxd
Copy link
Contributor

Description

Removes avoid_print: ignore from analysis_options.yaml and replaces all print() in production with developer.log()

Related Issues

I would suggest switching from print to dart:developer as it is suggested here https://flutter.dev/docs/testing/code-debugging#logging
Or there is a specific reason to stick with print?

Originally posted in #519 (comment)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@miquelbeltran
Copy link
Member

Hi @adityathakurxd and @vbuberen because we have two PRs solving the same issue, we cannot merge the two of them. This one landed first so I will go with this one, but I will add the hacktoberfest labels to both (if that was your goal).

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 12, 2021
@miquelbeltran miquelbeltran merged commit 6aaeda0 into fluttercommunity:main Oct 12, 2021
@vbuberen vbuberen mentioned this pull request Oct 12, 2021
9 tasks
Sameerkash pushed a commit to Sameerkash/plus_plugins that referenced this pull request Oct 12, 2021
Co-authored-by: Aditya Thakur <adityathakurxd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants