Refactor cmake build system #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slabasan
force-pushed
the
refactor-cmake
branch
4 times, most recently
from
3c21f92 to
417f27d
Compare
slabasan
force-pushed
the
refactor-cmake
branch
from
417f27d to
cf83aba
Compare
slabasan
commented
Feb 22, 2024
|
|
||
| include(cmake/Setup3rdParty.cmake) | ||
|
|
||
| include(GNUInstallDirs) | ||
| set(CMAKE_SKIP_BUILD_RPATH FALSE) | ||
| set(CMAKE_BUILD_WITH_INSTALL_RPATH FALSE) | ||
| set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE) | ||
| set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}") |
There was a problem hiding this comment.
Revisit setting rpath
| # Build Options | ||
| option(PERFFLOWASPECT_WITH_CUDA "Build CUDA smoketest" ON) | ||
| option(PERFFLOWASPECT_WITH_MPI "Build MPI smoketest" ON) | ||
| option(PERFFLOWASPECT_WITH_MULTITHREADS "Build multi-threaded smoketest" ON) |
There was a problem hiding this comment.
Maybe a single build option for all tests, tests will build only if it exists (e.g. CUDA for example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_packageto per-package files in cmake directoryfind_packageforjanssonFixes #132