Deleting the Terraform object before deleting its source #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixed the Terraform deletion logic of the Branch Planner by making sure that the Terraform object is deleted before the source. It also changed the plan object creation logic by making sure that - the plan object won't delete the live resources. - the plan object won't create any output secrets. Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
There was a bug inside the createLabels function that modified the labels of the original objects instead of creating a new map. This commit fixed it. Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
chanwit
force-pushed
the
delete-tf-before-source
branch
from
d4d9354 to
41c4445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #898
This PR contains two commits.
of the Branch Planner by making sure that the
Terraform object is deleted before the source.
It also changed the plan object creation logic by
making sure that
that modified the labels of the original objects
instead of creating a new map. The second commit fixed it.