Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement local gRPC server for terraform runner #67

Merged
merged 8 commits into from
Jan 31, 2022
Merged

implement local gRPC server for terraform runner #67

merged 8 commits into from
Jan 31, 2022

Conversation

chanwit
Copy link
Collaborator

@chanwit chanwit commented Jan 28, 2022 •
edited
Loading

Fix #68

  • It must be an gRPC server wrapping around TFExec
  • Its local version must be able to use inside the TF-controller, and all current tests pass.
  • the gRPC server must support executing a command for each step in the life-cycle
    • receive tar.gz
    • init
    • plan for drift detection
    • plan
    • apply
    • show
    • output
  • rebase
  • re-test

@chanwit chanwit force-pushed the tf-runner branch 7 times, most recently from 4ad5bfb to b605ee2 Compare January 30, 2022 16:57
@chanwit chanwit changed the title [WIP] implement terraform runner implement local gRPC server for terraform runner Jan 30, 2022
@chanwit chanwit marked this pull request as ready for review January 30, 2022 17:04
@chanwit chanwit requested a review from phoban01 January 31, 2022 14:15
phoban01
phoban01 suggested changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@phoban01 phoban01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @chanwit.

One suggestion and I'm also seeing one test failure consistently: Test_000230_drift_detection_only_mode

Seems to be ok in CI however 🤷

controllers/terraform_controller.go Outdated Show resolved Hide resolved
@chanwit
Copy link
Collaborator Author

chanwit commented Jan 31, 2022 

PASS
coverage: 66.0% of statements
ok      github.com/chanwit/tf-controller/controllers    143.430s        coverage: 66.0% of statements

It passed on my box.
Yeah, we need sometime to take a look and fix these flaky tests.

phoban01
phoban01 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@phoban01 phoban01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

We can do some housekeeping once we get the runner work across the line.

@chanwit chanwit merged commit e8e8b95 into main Jan 31, 2022
@chanwit chanwit deleted the tf-runner branch February 8, 2022 13:08
@turkenh turkenh mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoban01 phoban01 phoban01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement local RPC server for TF Runner
2 participants
@chanwit @phoban01