Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flux2): add webhook-receiver ingress #202

Merged
merged 3 commits into from
Nov 5, 2023

Conversation

sebastiangaiser
Copy link
Contributor

@sebastiangaiser sebastiangaiser commented Nov 5, 2023

What this PR does / why we need it:

Ingress resource for notificationController's receiver webhook service

Used values for testing:

notificationController:
  webhookReceiver:
    ingress:
      create: true
      ingressClassName: nginx
      annotations:
        kubernetes.io/ingress.class: nginx
        kubernetes.io/tls-acme: "true"
      hosts:
        - host: flux-webhook.example.com
          paths:
            - path: /
              pathType: ImplementationSpecific
      tls:
        - secretName: flux-webhook-tls
          hosts:
            - flux-webhook.example.com

Which issue this PR fixes

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested
  • Update artifacthub.io/changes in Chart.yaml
  • Run make reviewable

@sebastiangaiser sebastiangaiser force-pushed the main branch 2 times, most recently from 4b415a4 to 90773db Compare November 5, 2023 12:27
Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
@sebastiangaiser
Copy link
Contributor Author

sebastiangaiser commented Nov 5, 2023

This seams to be related to the failing tests. Shall I bump the version, too?

@stefanprodan
Copy link
Member

Yes please bump the version

Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
@stefanprodan
Copy link
Member

You need to bump the patch version of all charts due to the readme change.

This was referenced Nov 5, 2023
Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @sebastiangaiser 🥇

@stefanprodan stefanprodan merged commit 5fea58a into fluxcd-community:main Nov 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ingress objects for notification controller
2 participants