Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KEDA HTTPScaledObjects support #1748

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kahirokunn
Copy link
Contributor

No description provided.

Verified

This commit was signed with the committer’s verified signature.
kahirokunn kahirokunn
…Route

Signed-off-by: kahirokunn <okinakahiro@gmail.com>

Verified

This commit was signed with the committer’s verified signature.
kahirokunn kahirokunn
- Fix spelling of AutoscalerReference (was AutoscalerRefernce) in type definition and struct field

Signed-off-by: kahirokunn <okinakahiro@gmail.com>

Verified

This commit was signed with the committer’s verified signature.
kahirokunn kahirokunn
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@kahirokunn kahirokunn marked this pull request as draft December 17, 2024 07:11
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 11.95721% with 1399 lines in your changes missing coverage. Please review.

Project coverage is 37.43%. Comparing base (febc327) to head (69dda9f).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/apis/http/v1alpha1/zz_generated.deepcopy.go 0.00% 497 Missing ⚠️
pkg/apis/http/v1alpha1/httpscalingset_defaults.go 0.00% 95 Missing ⚠️
pkg/canary/http_scaled_object_reconciler.go 0.00% 89 Missing ⚠️
...d/http/v1alpha1/fake/fake_clusterhttpscalingset.go 0.00% 77 Missing ⚠️
.../typed/http/v1alpha1/fake/fake_httpscaledobject.go 0.00% 77 Missing ⚠️
...ed/typed/http/v1alpha1/fake/fake_httpscalingset.go 0.00% 77 Missing ⚠️
...ped/gatewayapi/v1beta1/fake/fake_referencegrant.go 22.05% 52 Missing and 1 partial ⚠️
pkg/apis/flagger/v1beta1/zz_generated.deepcopy.go 3.77% 50 Missing and 1 partial ⚠️
...g/apis/gatewayapi/v1beta1/zz_generated.deepcopy.go 41.37% 50 Missing and 1 partial ⚠️
...ntset/versioned/typed/http/v1alpha1/http_client.go 0.00% 48 Missing ⚠️
... and 30 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
- Coverage   39.27%   37.43%   -1.85%     
==========================================
  Files         284      311      +27     
  Lines       22379    23872    +1493     
==========================================
+ Hits         8789     8936     +147     
- Misses      12643    13978    +1335     
- Partials      947      958      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants