Add buffer to channel for Notify

Package signal will not block sending to c: the caller must ensure that c has sufficient buffer space to keep up with the expected signal rate. See https://golang.org/pkg/os/signal/#Notify
fluxcd · Oct 8, 2018 · 2162c3e · 2162c3e
1 parent 5648746
commit 2162c3e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cmd/fluxd/main.go b/cmd/fluxd/main.go
@@ -332,7 +332,7 @@ func main() {
 	shutdownWg := &sync.WaitGroup{}
 
 	go func() {
-		c := make(chan os.Signal)
+		c := make(chan os.Signal, 1)
 		signal.Notify(c, syscall.SIGINT, syscall.SIGTERM)
 		errc <- fmt.Errorf("%s", <-c)
 	}()

diff --git a/cmd/helm-operator/main.go b/cmd/helm-operator/main.go
@@ -139,7 +139,7 @@ func main() {
 	shutdownWg := &sync.WaitGroup{}
 
 	go func() {
-		c := make(chan os.Signal)
+		c := make(chan os.Signal, 1)
 		signal.Notify(c, syscall.SIGINT, syscall.SIGTERM)
 		errc <- fmt.Errorf("%s", <-c)
 	}()